Oda/managing-apps
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor FuturesBot and SpotBot to utilize ticker enum for candle retrieval

Browse Source 
- Updated GetCurrentCandleForPositionClose method in both FuturesBot and SpotBot to parse the ticker parameter into an enum, enhancing type safety and clarity.
- Adjusted TradingBotBase to use the position's ticker for candle retrieval, ensuring consistency across trading bot implementations.
This commit is contained in:
cryptooda
2026-01-07 01:44:05 +07:00
parent a0859b6a0d
commit bc4725ca19
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Managing.Application/Bots/FuturesBot.cs
View File

@@ -77,8 +77,10 @@ public class FuturesBot : TradingBotBase
protected override async Task<Candle> GetCurrentCandleForPositionClose(Account account, string ticker)
{
// For live trading, get real-time candle from exchange
// ticker parameter is a string representation of the position's ticker
var tickerEnum = Enum.Parse<Ticker>(ticker);
return await ServiceScopeHelpers.WithScopedService<IExchangeService, Candle>(_scopeFactory,
async exchangeService => await exchangeService.GetCandle(Account, Config.Ticker, DateTime.UtcNow));
async exchangeService => await exchangeService.GetCandle(Account, tickerEnum, DateTime.UtcNow));
}
protected override async Task<bool> CheckBrokerPositions()

4
src/Managing.Application/Bots/SpotBot.cs
View File

@@ -143,8 +143,10 @@ public class SpotBot : TradingBotBase
protected override async Task<Candle> GetCurrentCandleForPositionClose(Account account, string ticker)
{
// For live trading, get real-time candle from exchange
// ticker parameter is a string representation of the position's ticker
var tickerEnum = Enum.Parse<Ticker>(ticker);
return await ServiceScopeHelpers.WithScopedService<IExchangeService, Candle>(_scopeFactory,
async exchangeService => await exchangeService.GetCandle(Account, Config.Ticker, DateTime.UtcNow));
async exchangeService => await exchangeService.GetCandle(Account, tickerEnum, DateTime.UtcNow));
}
protected override async Task<bool> CheckBrokerPositions()

4
src/Managing.Application/Bots/TradingBotBase.cs
View File

@@ -477,7 +477,7 @@ public abstract class TradingBotBase : ITradingBot
{
lastCandle = TradingBox.IsBacktestTrading(Config.TradingType)
? LastCandle
: await exchangeService.GetCandle(Account, Config.Ticker,
: await exchangeService.GetCandle(Account, positionForSignal.Ticker,
DateTime.UtcNow);
});
@@ -1177,7 +1177,7 @@ public abstract class TradingBotBase : ITradingBot
{
if (Positions.ContainsKey(position.Identifier))
{
Candle currentCandle = await GetCurrentCandleForPositionClose(Account, Config.Ticker.ToString());
Candle currentCandle = await GetCurrentCandleForPositionClose(Account, position.Ticker.ToString());
// Try broker history reconciliation first
var brokerHistoryReconciled = await ReconcileWithBrokerHistory(position, currentCandle);