Oda/managing-apps
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove extra message on the low usdc while position open

Browse Source
This commit is contained in:
cryptooda
2025-10-05 02:49:33 +07:00
parent 4aad20b30b
commit b25f0be083
1 changed files with 16 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/Managing.Application/Bots/Grains/LiveTradingBotGrain.cs
View File

@@ -259,9 +259,10 @@ public class LiveTradingBotGrain : Grain, ILiveTradingBotGrain, IRemindable
var hasOpenPositions = await HasOpenPositionsInDatabaseAsync();
if (hasOpenPositions)
{
_logger.LogWarning("Cannot stop LiveTradingBotGrain {GrainId} - bot has open positions in database",
this.GetPrimaryKey());
throw new InvalidOperationException("Cannot stop bot while it has open positions. Please close all positions first.");
_logger.LogWarning("Cannot stop strategy {Name} : strategy has open positions in database",
_tradingBot?.Config.Name);
throw new InvalidOperationException(
"Cannot stop bot while it has open positions. Please close all positions first.");
}
}
@@ -372,24 +373,12 @@ public class LiveTradingBotGrain : Grain, ILiveTradingBotGrain, IRemindable
if (!balanceCheckResult.IsSuccessful)
{
// Log the specific reason for the failure
await _tradingBot.LogWarning(
$"Balance check failed: {balanceCheckResult.Message} (Reason: {balanceCheckResult.FailureReason})");
// Check if the bot should stop due to this failure
if (balanceCheckResult.ShouldStopBot)
{
await _tradingBot.LogWarning(
$"Stopping bot due to balance check failure: {balanceCheckResult.Message}");
await StopAsync();
return;
}
else
{
// Skip this execution cycle but continue running
await _tradingBot.LogInformation("Skipping this execution cycle due to balance check failure.");
return;
}
}
}
catch (Exception ex)
@@ -616,9 +605,10 @@ public class LiveTradingBotGrain : Grain, ILiveTradingBotGrain, IRemindable
var hasOpenPositions = await HasOpenPositionsInDatabaseAsync();
if (hasOpenPositions)
{
_logger.LogWarning("Cannot delete LiveTradingBotGrain {GrainId} - bot has open positions in database",
_logger.LogWarning("Cannot delete LiveTradingBotGrain {GrainId} - bot has open positions in database",
this.GetPrimaryKey());
throw new InvalidOperationException("Cannot delete bot while it has open positions. Please close all positions first.");
throw new InvalidOperationException(
"Cannot delete bot while it has open positions. Please close all positions first.");
}
try
@@ -880,20 +870,21 @@ public class LiveTradingBotGrain : Grain, ILiveTradingBotGrain, IRemindable
{
// For non-running bots, check grain state positions
var hasOpenPositions = _state.State.Positions?.Values.Any(p => !p.IsFinished()) ?? false;
_logger.LogDebug("Bot {GrainId} has open positions: {HasOpenPositions} (from grain state)",
_logger.LogDebug("Bot {GrainId} has open positions: {HasOpenPositions} (from grain state)",
this.GetPrimaryKey(), hasOpenPositions);
return Task.FromResult(hasOpenPositions);
}
// For running bots, check live positions
var hasLiveOpenPositions = _tradingBot.Positions?.Values.Any(p => !p.IsFinished()) ?? false;
_logger.LogDebug("Bot {GrainId} has open positions: {HasOpenPositions} (from live data)",
_logger.LogDebug("Bot {GrainId} has open positions: {HasOpenPositions} (from live data)",
this.GetPrimaryKey(), hasLiveOpenPositions);
return Task.FromResult(hasLiveOpenPositions);
}
catch (Exception ex)
{
_logger.LogError(ex, "Error checking open positions for LiveTradingBotGrain {GrainId}", this.GetPrimaryKey());
_logger.LogError(ex, "Error checking open positions for LiveTradingBotGrain {GrainId}",
this.GetPrimaryKey());
return Task.FromResult(false); // Default to false on error to avoid blocking autoswap
}
}
@@ -912,16 +903,17 @@ public class LiveTradingBotGrain : Grain, ILiveTradingBotGrain, IRemindable
async tradingService => await tradingService.GetPositionsByInitiatorIdentifierAsync(botId));
var hasOpenPositions = positions?.Any(p => !p.IsFinished()) ?? false;
_logger.LogDebug("Bot {GrainId} has open positions in database: {HasOpenPositions}",
_logger.LogDebug("Bot {GrainId} has open positions in database: {HasOpenPositions}",
botId, hasOpenPositions);
if (hasOpenPositions)
{
var openPositions = positions?.Where(p => !p.IsFinished()).ToList() ?? new List<Position>();
_logger.LogWarning("Bot {GrainId} cannot be stopped - has {Count} open positions in database: {Positions}",
_logger.LogWarning(
"Bot {GrainId} cannot be stopped - has {Count} open positions in database: {Positions}",
botId, openPositions.Count, string.Join(", ", openPositions.Select(p => p.Identifier)));
}
return hasOpenPositions;
}
catch (Exception ex)