Oda/managing-apps
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove doc required

Browse Source
This commit is contained in:
cryptooda
2025-10-28 17:55:41 +07:00
parent da908d7da2
commit 1181a0920a
2 changed files with 38 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
src/Managing.Api/Controllers/TradingController.cs
View File

@@ -105,7 +105,7 @@ public class TradingController : BaseController
public async Task<ActionResult<Position>> ClosePosition(Guid identifier)
{
var position = await _tradingService.GetPositionByIdentifierAsync(identifier);
var result = await _closeTradeCommandHandler.Handle(new ClosePositionCommand(position, position.AccountId));
return Ok(result);
}
@@ -190,7 +190,8 @@ public class TradingController : BaseController
// Check if user has permission to initialize this address
if (!await CanUserInitializeAddress(user.Name, publicAddress))
{
return Forbid("You don't have permission to initialize this wallet address. You can only initialize your own wallet addresses.");
return Forbid(
"You don't have permission to initialize this wallet address. You can only initialize your own wallet addresses.");
}
var result = await _tradingService.InitPrivyWallet(publicAddress, TradingExchanges.GmxV2);
@@ -228,19 +229,22 @@ public class TradingController : BaseController
// Regular users can only initialize their own addresses
// Check if the address belongs to one of the user's accounts
var account = await _accountService.GetAccountByKey(publicAddress, true, false);
if (account?.User?.Name == userName)
{
_logger.LogInformation("User {UserName} initializing their own address {Address}", userName, publicAddress);
_logger.LogInformation("User {UserName} initializing their own address {Address}", userName,
publicAddress);
return true;
}
_logger.LogWarning("User {UserName} attempted to initialize address {Address} that doesn't belong to them", userName, publicAddress);
_logger.LogWarning("User {UserName} attempted to initialize address {Address} that doesn't belong to them",
userName, publicAddress);
return false;
}
catch (Exception ex)
{
_logger.LogWarning(ex, "Unable to verify ownership of address {Address} for user {UserName}", publicAddress, userName);
_logger.LogWarning(ex, "Unable to verify ownership of address {Address} for user {UserName}", publicAddress,
userName);
return false;
}
}
@@ -268,11 +272,6 @@ public class TradingController : BaseController
return BadRequest("Strategy is required.");
}
if (string.IsNullOrWhiteSpace(request.DocumentationUrl))
{
return BadRequest("Documentation URL is required.");
}
if (string.IsNullOrWhiteSpace(request.RequesterName))
{
return BadRequest("Requester name is required.");
@@ -281,7 +280,7 @@ public class TradingController : BaseController
try
{
var webhookUrl = _configuration["N8n:IndicatorRequestWebhookUrl"];
if (string.IsNullOrEmpty(webhookUrl))
{
_logger.LogError("N8n indicator request webhook URL is not configured");
@@ -289,26 +288,26 @@ public class TradingController : BaseController
}
var httpClient = _httpClientFactory.CreateClient();
_logger.LogInformation(
"Submitting indicator request: {IndicatorName} - {Strategy} by {Requester}",
request.IndicatorName,
request.StrategyDescription,
request.IndicatorName,
request.StrategyDescription,
request.RequesterName);
// Send as JSON payload
var response = await httpClient.PostAsJsonAsync(webhookUrl, request);
if (response.IsSuccessStatusCode)
{
_logger.LogInformation(
"Successfully submitted indicator request: {IndicatorName} by {Requester}",
request.IndicatorName,
request.IndicatorName,
request.RequesterName);
return Ok(new
{
Success = true,
return Ok(new
{
Success = true,
Message = "Indicator request submitted successfully.",
IndicatorName = request.IndicatorName,
Strategy = request.StrategyDescription,
@@ -322,21 +321,21 @@ public class TradingController : BaseController
"Failed to submit indicator request. Status: {StatusCode}, Response: {Response}",
response.StatusCode,
responseContent);
return StatusCode(500, new
{
Success = false,
Error = $"Failed to submit indicator request. Status: {response.StatusCode}"
return StatusCode(500, new
{
Success = false,
Error = $"Failed to submit indicator request. Status: {response.StatusCode}"
});
}
}
catch (Exception ex)
{
_logger.LogError(ex, "Error submitting indicator request: {IndicatorName}", request.IndicatorName);
return StatusCode(500, new
{
Success = false,
Error = "An error occurred while submitting the indicator request."
return StatusCode(500, new
{
Success = false,
Error = "An error occurred while submitting the indicator request."
});
}
}

12
src/Managing.Api/Models/Requests/IndicatorRequestDto.cs
View File

@@ -1,5 +1,7 @@
#nullable enable
using System.ComponentModel.DataAnnotations;
namespace Managing.Api.Models.Requests;
/// <summary>
@@ -10,17 +12,19 @@ public class IndicatorRequestDto
/// <summary>
/// Name of the indicator (e.g., "MACD", "RSI", "Bollinger Bands")
/// </summary>
public string IndicatorName { get; set; } = string.Empty;
[Required]
public string IndicatorName { get; set; }
/// <summary>
/// Strategy or description of how the indicator is used (e.g., "MACD Cross", "RSI Divergence")
/// </summary>
[Required]
public string StrategyDescription { get; set; } = string.Empty;
/// <summary>
/// Primary documentation URL for the indicator
/// </summary>
public string DocumentationUrl { get; set; } = string.Empty;
public string? DocumentationUrl { get; set; }
/// <summary>
/// Image URL for the indicator (optional) - can be a chart, diagram, or visual representation
@@ -30,6 +34,6 @@ public class IndicatorRequestDto
/// <summary>
/// Name of the person requesting the indicator
/// </summary>
[Required]
public string RequesterName { get; set; } = string.Empty;
}
}