From ff7e4ed3d3f25051ca2325aa641573a55e5ed793 Mon Sep 17 00:00:00 2001 From: cryptooda Date: Tue, 7 Oct 2025 16:10:14 +0700 Subject: [PATCH] un-stopped bot return status "stopped" instead of the error --- src/Managing.Application/Bots/Grains/LiveTradingBotGrain.cs | 2 +- src/Managing.Application/ManageBot/BotService.cs | 2 +- src/Managing.WebApp/src/generated/ManagingApi.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Managing.Application/Bots/Grains/LiveTradingBotGrain.cs b/src/Managing.Application/Bots/Grains/LiveTradingBotGrain.cs index 16f18390..c3178028 100644 --- a/src/Managing.Application/Bots/Grains/LiveTradingBotGrain.cs +++ b/src/Managing.Application/Bots/Grains/LiveTradingBotGrain.cs @@ -277,7 +277,7 @@ public class LiveTradingBotGrain : Grain, ILiveTradingBotGrain, IRemindable var hasOpenPositions = await HasOpenPositionsInDatabaseAsync(); if (hasOpenPositions) { - _logger.LogWarning("Cannot stop strategy {Name} : strategy has open positions in database", + _logger.LogWarning("Stopping bot {Name} while it still has open positions in database. Trading loop will stop but positions remain managed by system.", _tradingBot?.Config.Name); throw new InvalidOperationException( "Cannot stop bot while it has open positions. Please close all positions first."); diff --git a/src/Managing.Application/ManageBot/BotService.cs b/src/Managing.Application/ManageBot/BotService.cs index 76768b4e..20c6c6e7 100644 --- a/src/Managing.Application/ManageBot/BotService.cs +++ b/src/Managing.Application/ManageBot/BotService.cs @@ -60,7 +60,7 @@ namespace Managing.Application.ManageBot catch (Exception e) { _tradingBotLogger.LogError(e, "Error stopping bot {Identifier}", identifier); - return BotStatus.Stopped; + throw; } } diff --git a/src/Managing.WebApp/src/generated/ManagingApi.ts b/src/Managing.WebApp/src/generated/ManagingApi.ts index 86c3eec0..0b7241da 100644 --- a/src/Managing.WebApp/src/generated/ManagingApi.ts +++ b/src/Managing.WebApp/src/generated/ManagingApi.ts @@ -1767,7 +1767,7 @@ export class DataClient extends AuthorizedApiBase { url_ = url_.replace(/[?&]$/, ""); let options_: RequestInit = { - method: "POST", + method: "GET", headers: { "Accept": "application/json" }