Refactor pagination sorting parameters across multiple controllers and services to use the new SortDirection enum; update related API models and TypeScript definitions for consistency. Fix minor documentation and naming inconsistencies in the Bot and Data controllers.
This commit is contained in:
@@ -112,7 +112,7 @@ public class BacktestExecutorTests : BaseTests, IDisposable
|
||||
var scenario = new Scenario("ETH_BacktestScenario");
|
||||
var rsiDivIndicator = ScenarioHelpers.BuildIndicator(IndicatorType.RsiDivergence, "RsiDiv", period: 14);
|
||||
scenario.Indicators = new List<IndicatorBase> { (IndicatorBase)rsiDivIndicator };
|
||||
scenario.LoopbackPeriod = 15;
|
||||
scenario.LookbackPeriod = 15;
|
||||
|
||||
var config = new TradingBotConfig
|
||||
{
|
||||
@@ -207,7 +207,7 @@ public class BacktestExecutorTests : BaseTests, IDisposable
|
||||
var scenario = new Scenario("ETH_BacktestScenario");
|
||||
var rsiDivIndicator = ScenarioHelpers.BuildIndicator(IndicatorType.RsiDivergence, "RsiDiv", period: 14);
|
||||
scenario.Indicators = new List<IndicatorBase> { (IndicatorBase)rsiDivIndicator };
|
||||
scenario.LoopbackPeriod = 15;
|
||||
scenario.LookbackPeriod = 15;
|
||||
|
||||
var config = new TradingBotConfig
|
||||
{
|
||||
@@ -297,7 +297,7 @@ public class BacktestExecutorTests : BaseTests, IDisposable
|
||||
var scenario = new Scenario("ETH_BacktestScenario");
|
||||
var rsiDivIndicator = ScenarioHelpers.BuildIndicator(IndicatorType.RsiDivergence, "RsiDiv", period: 14);
|
||||
scenario.Indicators = new List<IndicatorBase> { (IndicatorBase)rsiDivIndicator };
|
||||
scenario.LoopbackPeriod = 15;
|
||||
scenario.LookbackPeriod = 15;
|
||||
|
||||
var config = new TradingBotConfig
|
||||
{
|
||||
@@ -387,7 +387,7 @@ public class BacktestExecutorTests : BaseTests, IDisposable
|
||||
var emaCrossIndicator = ScenarioHelpers.BuildIndicator(IndicatorType.EmaCross, "EmaCross", period: 21);
|
||||
scenario.Indicators = new List<IndicatorBase>
|
||||
{ (IndicatorBase)rsiDivIndicator, (IndicatorBase)emaCrossIndicator };
|
||||
scenario.LoopbackPeriod = 15; // 15 minutes loopback period as requested
|
||||
scenario.LookbackPeriod = 15; // 15 minutes loopback period as requested
|
||||
|
||||
var config = new TradingBotConfig
|
||||
{
|
||||
@@ -488,7 +488,7 @@ public class BacktestExecutorTests : BaseTests, IDisposable
|
||||
Console.WriteLine($"📈 Win Rate: {result.WinRate}% (Expected: {expectedWinRatePercent}%)");
|
||||
Console.WriteLine($"📈 Growth: {result.GrowthPercentage:F2}% (Expected: {expectedGrowthPercentage:F2}%)");
|
||||
Console.WriteLine(
|
||||
$"🎭 Scenario: {scenario.Name} ({scenario.Indicators.Count} indicators, LoopbackPeriod: {scenario.LoopbackPeriod})");
|
||||
$"🎭 Scenario: {scenario.Name} ({scenario.Indicators.Count} indicators, LoopbackPeriod: {scenario.LookbackPeriod})");
|
||||
|
||||
// Performance assertion - should be reasonably fast even with 2 indicators
|
||||
Assert.True(candlesPerSecond > 200,
|
||||
@@ -510,7 +510,7 @@ public class BacktestExecutorTests : BaseTests, IDisposable
|
||||
var scenario = new Scenario("ETH_Spot_BacktestScenario");
|
||||
var rsiDivIndicator = ScenarioHelpers.BuildIndicator(IndicatorType.RsiDivergence, "RsiDiv", period: 14);
|
||||
scenario.Indicators = new List<IndicatorBase> { (IndicatorBase)rsiDivIndicator };
|
||||
scenario.LoopbackPeriod = 15;
|
||||
scenario.LookbackPeriod = 15;
|
||||
|
||||
var config = new TradingBotConfig
|
||||
{
|
||||
@@ -570,10 +570,10 @@ public class BacktestExecutorTests : BaseTests, IDisposable
|
||||
// Assert - Validate specific backtest results
|
||||
Assert.NotNull(result);
|
||||
Assert.IsType<LightBacktest>(result);
|
||||
|
||||
|
||||
// Verify TradingType is BacktestSpot
|
||||
Assert.Equal(TradingType.BacktestSpot, result.Config.TradingType);
|
||||
|
||||
|
||||
// Validate key metrics - Updated with actual backtest results
|
||||
Assert.Equal(1000.0m, result.InitialBalance);
|
||||
Assert.Equal(-71.63m, Math.Round(result.FinalPnl, 2));
|
||||
@@ -586,7 +586,7 @@ public class BacktestExecutorTests : BaseTests, IDisposable
|
||||
Assert.Equal(-0.107, Math.Round((double)(result.SharpeRatio ?? 0), 3));
|
||||
Assert.True(Math.Abs(result.Score - 0.0) < 0.001,
|
||||
$"Score {result.Score} should be within 0.001 of expected value 0.0");
|
||||
|
||||
|
||||
// Validate dates
|
||||
Assert.Equal(new DateTime(2025, 10, 14, 12, 0, 0), result.StartDate);
|
||||
Assert.Equal(new DateTime(2025, 10, 24, 11, 45, 0), result.EndDate);
|
||||
|
||||
Reference in New Issue
Block a user