Fix spot bot

src/Managing.Api/Controllers/BotController.cs

@@ -814,7 +814,7 @@ public class BotController : BaseController
                 UseForSignalFiltering = request.Config.UseForSignalFiltering,
                 UseForDynamicStopLoss = request.Config.UseForDynamicStopLoss,
                 // Set computed/default properties
-                TradingType = TradingType.Futures,
+                TradingType = request.Config.TradingType,
                 FlipPosition = request.Config.FlipPosition,
                 Name = request.Config.Name
             };
@@ -955,6 +955,13 @@ public class BotController : BaseController
             }
         }
 
+        var tradingType = request.Config.TradingType switch
+        {
+            TradingType.BacktestFutures => TradingType.Futures,
+            TradingType.BacktestSpot => TradingType.Spot,
+            _ => TradingType.Futures
+        };
+
         // Map the request to the full TradingBotConfig
         var config = new TradingBotConfig
         {
@@ -976,9 +983,9 @@ public class BotController : BaseController
             UseForSignalFiltering = request.Config.UseForSignalFiltering,
             UseForDynamicStopLoss = request.Config.UseForDynamicStopLoss,
             // Set computed/default properties
-            TradingType = TradingType.Futures,
             FlipPosition = request.Config.FlipPosition,
-            Name = request.Config.Name
+            Name = request.Config.Name,
+            TradingType = tradingType
         };
 
         return (config, user);

src/Managing.Application/Backtests/BacktestJobService.cs

@@ -197,7 +197,7 @@ public class JobService
                     Timeframe = backtestRequest.Config.Timeframe,
                     IsForWatchingOnly = backtestRequest.Config.IsForWatchingOnly,
                     BotTradingBalance = backtestRequest.Config.BotTradingBalance,
-                    TradingType = TradingType.BacktestFutures,
+                    TradingType = backtestRequest.Config.TradingType,
                     CooldownPeriod = backtestRequest.Config.CooldownPeriod ?? 1,
                     MaxLossStreak = backtestRequest.Config.MaxLossStreak,
                     MaxPositionTimeHours = backtestRequest.Config.MaxPositionTimeHours,

src/Managing.Application/Backtests/Backtester.cs

@@ -447,7 +447,8 @@ namespace Managing.Application.Backtests
                                 UseSynthApi = universalConfig.UseSynthApi,
                                 UseForPositionSizing = universalConfig.UseForPositionSizing,
                                 UseForSignalFiltering = universalConfig.UseForSignalFiltering,
-                                UseForDynamicStopLoss = universalConfig.UseForDynamicStopLoss
+                                UseForDynamicStopLoss = universalConfig.UseForDynamicStopLoss,
+                                TradingType = universalConfig.TradingType
                             };
 
                             var backtestRequest = new RunBacktestRequest

src/Managing.Application/Bots/SpotBot.cs

@@ -544,6 +544,18 @@ public class SpotBot : TradingBotBase, ITradingBot
             return;
         }
 
+        // Ensure account is loaded before accessing Account.Exchange
+        if (Account == null)
+        {
+            Logger.LogWarning("Cannot update signals: Account is null. Loading account...");
+            await LoadAccountAsync();
+            if (Account == null)
+            {
+                Logger.LogError("Cannot update signals: Account failed to load");
+                return;
+            }
+        }
+
         // Live trading: use ScenarioRunnerGrain to get signals
         await ServiceScopeHelpers.WithScopedService<IGrainFactory>(_scopeFactory, async grainFactory =>
         {

src/Managing.Application/ManageBot/StartCopyTradingCommandHandler.cs

@@ -187,7 +187,7 @@ namespace Managing.Application.ManageBot
                 MasterBotUserId = masterBot.User.Id,
 
                 // Set computed/default properties
-                TradingType = TradingType.Futures,
+                TradingType = masterConfig.TradingType,
                 Name = masterConfig.Name
             };
 

src/Managing.Application/Scenarios/ScenarioRunnerGrain.cs

@@ -60,11 +60,24 @@ public class ScenarioRunnerGrain : Grain, IScenarioRunnerGrain
     {
         try
         {
+            if (candle == null)
+            {
+                _logger.LogWarning($"Cannot generate signals: candle is null for {config.Ticker} for {config.Name}");
+                return null;
+            }
+
             var candlesHashSet = await GetCandlesAsync(tradingExchanges, config);
             // Convert to ordered List to preserve chronological order for indicators
             var candlesList = candlesHashSet.OrderBy(c => c.Date).ToList();
             
-            if (candlesList.LastOrDefault()!.Date <= candle.Date)
+            if (candlesList.Count == 0)
+            {
+                _logger.LogWarning($"No candles available for {config.Ticker} for {config.Name}");
+                return null; // No candles available, cannot generate signal
+            }
+
+            var lastCandle = candlesList.Last();
+            if (lastCandle.Date <= candle.Date)
             {
                 _logger.LogWarning($"No new candles for {config.Ticker} for {config.Name}");
                 return null; // No new candles, no need to generate a signal

src/Managing.Application/Workers/BundleBacktestHealthCheckWorker.cs

@@ -22,7 +22,10 @@ public class BundleBacktestHealthCheckWorker : BackgroundService
     private readonly ILogger<BundleBacktestHealthCheckWorker> _logger;
     private readonly TimeSpan _checkInterval = TimeSpan.FromMinutes(30);
     private readonly TimeSpan _inactiveThreshold = TimeSpan.FromMinutes(2); // Check bundles inactive for 2+ minutes
-    private readonly TimeSpan _stuckThreshold = TimeSpan.FromHours(2); // Consider bundle stuck if no progress for 2 hours
+
+    private readonly TimeSpan
+        _stuckThreshold = TimeSpan.FromHours(2); // Consider bundle stuck if no progress for 2 hours
+
     private readonly IMessengerService _messengerService;
 
     public BundleBacktestHealthCheckWorker(
@@ -80,8 +83,10 @@ public class BundleBacktestHealthCheckWorker : BackgroundService
         _logger.LogInformation("Starting bundle health check...");
 
         // Check bundles in Pending and Running status
-        var pendingBundles = await backtestRepository.GetBundleBacktestRequestsByStatusAsync(BundleBacktestRequestStatus.Pending);
+        var pendingBundles =
-        var runningBundles = await backtestRepository.GetBundleBacktestRequestsByStatusAsync(BundleBacktestRequestStatus.Running);
+            await backtestRepository.GetBundleBacktestRequestsByStatusAsync(BundleBacktestRequestStatus.Pending);
+        var runningBundles =
+            await backtestRepository.GetBundleBacktestRequestsByStatusAsync(BundleBacktestRequestStatus.Running);
 
         // Only check bundles that haven't been updated in more than the inactive threshold
         var inactiveThresholdTime = DateTime.UtcNow.Add(-_inactiveThreshold);
@@ -138,7 +143,8 @@ public class BundleBacktestHealthCheckWorker : BackgroundService
 
         _logger.LogDebug(
             "Bundle {BundleRequestId} ({Status}): Expected {Expected} jobs, Found {Actual} jobs, Completed {Completed}/{Total}",
-            bundle.RequestId, bundle.Status, expectedJobCount, actualJobCount, bundle.CompletedBacktests, bundle.TotalBacktests);
+            bundle.RequestId, bundle.Status, expectedJobCount, actualJobCount, bundle.CompletedBacktests,
+            bundle.TotalBacktests);
 
         // Check 1: Missing jobs - bundle has no jobs or fewer jobs than expected
         if (actualJobCount == 0 || actualJobCount < expectedJobCount)
@@ -172,7 +178,8 @@ public class BundleBacktestHealthCheckWorker : BackgroundService
 
                 if (allJobsPending || hasFailedJobs)
                 {
-                    await HandleStalePendingBundleAsync(bundle, timeSinceCreation, jobs, backtestRepository, jobRepository);
+                    await HandleStalePendingBundleAsync(bundle, timeSinceCreation, jobs, backtestRepository,
+                        jobRepository);
                     return (StuckCount: 1, MissingJobsCount: 0, HealthyCount: 0);
                 }
             }
@@ -184,7 +191,8 @@ public class BundleBacktestHealthCheckWorker : BackgroundService
         var totalProcessedJobs = completedJobs + failedJobs;
 
         if (totalProcessedJobs == bundle.TotalBacktests &&
-            (bundle.Status == BundleBacktestRequestStatus.Running || bundle.Status == BundleBacktestRequestStatus.Pending))
+            (bundle.Status == BundleBacktestRequestStatus.Running ||
+             bundle.Status == BundleBacktestRequestStatus.Pending))
         {
             await HandleCompletedBundleAsync(bundle, completedJobs, failedJobs, backtestRepository);
             return (StuckCount: 0, MissingJobsCount: 0, HealthyCount: 1);
@@ -244,7 +252,8 @@ public class BundleBacktestHealthCheckWorker : BackgroundService
             var missingRequests = allBacktestRequests
                 .Where(req =>
                 {
-                    var signature = $"{req.Config.Ticker}_{req.Config.Timeframe}_{req.Config.Name}_{req.StartDate:yyyyMMdd}_{req.EndDate:yyyyMMdd}";
+                    var signature =
+                        $"{req.Config.Ticker}_{req.Config.Timeframe}_{req.Config.Name}_{req.StartDate:yyyyMMdd}_{req.EndDate:yyyyMMdd}";
                     return !existingJobSignatures.Contains(signature);
                 })
                 .ToList();
@@ -324,7 +333,8 @@ public class BundleBacktestHealthCheckWorker : BackgroundService
             // Get the first account for the user
             using var scope = _scopeFactory.CreateScope();
             var accountService = scope.ServiceProvider.GetRequiredService<IAccountService>();
-            var accounts = await accountService.GetAccountsByUserAsync(bundleRequest.User, hideSecrets: true, getBalance: false);
+            var accounts =
+                await accountService.GetAccountsByUserAsync(bundleRequest.User, hideSecrets: true, getBalance: false);
             var firstAccount = accounts.FirstOrDefault();
 
             if (firstAccount == null)
@@ -362,7 +372,8 @@ public class BundleBacktestHealthCheckWorker : BackgroundService
                             UseSynthApi = universalConfig.UseSynthApi,
                             UseForPositionSizing = universalConfig.UseForPositionSizing,
                             UseForSignalFiltering = universalConfig.UseForSignalFiltering,
-                            UseForDynamicStopLoss = universalConfig.UseForDynamicStopLoss
+                            UseForDynamicStopLoss = universalConfig.UseForDynamicStopLoss,
+                            TradingType = universalConfig.TradingType
                         };
 
                         var backtestRequest = new RunBacktestRequest
@@ -435,7 +446,9 @@ public class BundleBacktestHealthCheckWorker : BackgroundService
                 "Bundle {BundleRequestId} has all jobs completed ({Completed} completed, {Failed} failed). Updating bundle status.",
                 bundle.RequestId, completedJobs, failedJobs);
 
-            bundle.Status = failedJobs == 0 ? BundleBacktestRequestStatus.Completed : BundleBacktestRequestStatus.Completed;
+            bundle.Status = failedJobs == 0
+                ? BundleBacktestRequestStatus.Completed
+                : BundleBacktestRequestStatus.Completed;
             bundle.CompletedBacktests = completedJobs;
             bundle.FailedBacktests = failedJobs;
             bundle.CompletedAt = DateTime.UtcNow;
@@ -473,7 +486,8 @@ public class BundleBacktestHealthCheckWorker : BackgroundService
 
             // Update bundle timestamp to give it another chance
             bundle.UpdatedAt = DateTime.UtcNow;
-            bundle.ErrorMessage = $"Bundle was stuck. Reset {runningJobs.Count(j => j.Status == JobStatus.Pending)} stale jobs to pending.";
+            bundle.ErrorMessage =
+                $"Bundle was stuck. Reset {runningJobs.Count(j => j.Status == JobStatus.Pending)} stale jobs to pending.";
         }
 
         await backtestRepository.UpdateBundleBacktestRequestAsync(bundle);
@@ -585,4 +599,3 @@ public class BundleBacktestHealthCheckWorker : BackgroundService
         }
     }
 }
-

src/Managing.Application/Workers/BundleBacktestWorker.cs

@@ -403,7 +403,8 @@ public class BundleBacktestWorker : BaseWorker<BundleBacktestWorker>
                             UseSynthApi = universalConfig.UseSynthApi,
                             UseForPositionSizing = universalConfig.UseForPositionSizing,
                             UseForSignalFiltering = universalConfig.UseForSignalFiltering,
-                            UseForDynamicStopLoss = universalConfig.UseForDynamicStopLoss
+                            UseForDynamicStopLoss = universalConfig.UseForDynamicStopLoss,
+                            TradingType = universalConfig.TradingType
                         };
 
                         var backtestRequest = new RunBacktestRequest

src/Managing.Domain/Bots/TradingBotConfigRequest.cs

@@ -110,4 +110,6 @@ public class TradingBotConfigRequest
     /// Whether to use Synth predictions for dynamic stop-loss/take-profit adjustments
     /// </summary>
     public bool UseForDynamicStopLoss { get; set; } = true;
+
+    public TradingType TradingType { get; set; }
 }

src/Managing.WebApp/src/components/organism/UnifiedTradingModal/UnifiedTradingModal.tsx

@@ -25,6 +25,7 @@ import {
     Ticker,
     Timeframe,
     TradingBotConfigRequest,
+    TradingType,
     UpdateBotConfigRequest,
 } from '../../../generated/ManagingApi'
 import type {IUnifiedTradingConfigInput, UnifiedTradingModalProps} from '../../../global/type'
@@ -83,6 +84,7 @@ const UnifiedTradingModal: React.FC<UnifiedTradingModalProps> = ({
       flipOnlyWhenInProfit: true,
       balance: 10000,
       closeEarlyWhenProfitable: false,
+      tradingType: TradingType.BacktestSpot,
       useSynthApi: false,
       useForPositionSizing: true,
       useForSignalFiltering: true,
@@ -217,6 +219,7 @@ const UnifiedTradingModal: React.FC<UnifiedTradingModalProps> = ({
       setValue('useForPositionSizing', backtest.config.useForPositionSizing ?? true);
       setValue('useForSignalFiltering', backtest.config.useForSignalFiltering ?? true);
       setValue('useForDynamicStopLoss', backtest.config.useForDynamicStopLoss ?? true);
+      setValue('tradingType', (backtest.config as any).tradingType || TradingType.BacktestSpot);
 
       // Use backtest's money management as custom
       if (backtest.config.moneyManagement) {
@@ -259,6 +262,7 @@ const UnifiedTradingModal: React.FC<UnifiedTradingModalProps> = ({
       setValue('useForPositionSizing', backtest.config.useForPositionSizing ?? true);
       setValue('useForSignalFiltering', backtest.config.useForSignalFiltering ?? true);
       setValue('useForDynamicStopLoss', backtest.config.useForDynamicStopLoss ?? true);
+      setValue('tradingType', (backtest.config as any).tradingType || TradingType.BacktestSpot);
 
       // Set tickers for backtest (array)
       if (backtest.config.ticker) {
@@ -318,6 +322,7 @@ const UnifiedTradingModal: React.FC<UnifiedTradingModalProps> = ({
       setValue('useForPositionSizing', config.useForPositionSizing ?? true);
       setValue('useForSignalFiltering', config.useForSignalFiltering ?? true);
       setValue('useForDynamicStopLoss', config.useForDynamicStopLoss ?? true);
+      setValue('tradingType', (config as any).tradingType || TradingType.BacktestSpot);
 
       // Handle money management - if it exists, treat as custom for update mode
       if (config.moneyManagement) {
@@ -664,6 +669,7 @@ const UnifiedTradingModal: React.FC<UnifiedTradingModalProps> = ({
         useForPositionSizing: form.useForPositionSizing ?? true,
         useForSignalFiltering: form.useForSignalFiltering ?? true,
         useForDynamicStopLoss: form.useForDynamicStopLoss ?? true,
+        tradingType: form.tradingType || TradingType.BacktestSpot,
         moneyManagementName: showCustomMoneyManagement ? undefined : selectedMoneyManagement,
         moneyManagement: moneyManagement,
       };
@@ -889,6 +895,18 @@ const UnifiedTradingModal: React.FC<UnifiedTradingModalProps> = ({
               ))}
             </select>
           </FormInput>
+
+          {(mode === 'createBot' || mode === 'updateBot') && (
+            <FormInput label="Trading Type" htmlFor="tradingType">
+              <select
+                className="select select-bordered w-full"
+                {...register('tradingType', { required: true })}
+              >
+                <option value={TradingType.BacktestSpot}>Spot</option>
+                <option value={TradingType.BacktestFutures}>Futures</option>
+              </select>
+            </FormInput>
+          )}
         </div>
 
         {/* Money Management */}

src/Managing.WebApp/src/generated/ManagingApi.ts

@@ -5298,10 +5298,10 @@ export interface BundleBacktestUniversalConfig {
     isForWatchingOnly: boolean;
     botTradingBalance: number;
     botName: string;
+    tradingType: TradingType;
     flipPosition: boolean;
     cooldownPeriod?: number | null;
     maxLossStreak?: number;
-    tradingType?: TradingType;
     scenario?: ScenarioRequest | null;
     scenarioName?: string | null;
     maxPositionTimeHours?: number | null;

src/Managing.WebApp/src/generated/ManagingApiTypes.ts

@@ -803,6 +803,7 @@ export interface BundleBacktestUniversalConfig {
     isForWatchingOnly: boolean;
     botTradingBalance: number;
     botName: string;
+    tradingType: TradingType;
     flipPosition: boolean;
     cooldownPeriod?: number | null;
     maxLossStreak?: number;

src/Managing.WebApp/src/global/type.tsx

@@ -15,7 +15,8 @@ import type {
     Timeframe,
     TradeDirection,
     TradingBotResponse,
-    TradingExchanges
+    TradingExchanges,
+    TradingType
 } from '../generated/ManagingApi'
 import {FC, ReactNode} from 'react'
 
@@ -71,6 +72,7 @@ export type IBacktestsFormInput = {
   maxPositionTimeHours?: number | null
   flipOnlyWhenInProfit?: boolean
   closeEarlyWhenProfitable?: boolean
+  tradingType?: TradingType
   // Synth API fields
   useSynthApi?: boolean
   useForPositionSizing?: boolean