Fix global PNL

src/Managing.Application/Grains/PlatformSummaryGrain.cs

@@ -106,9 +106,11 @@ public class PlatformSummaryGrain : Grain, IPlatformSummaryGrain, IRemindable
             var totalAgents = agents.Count();
             var totalActiveStrategies = strategies.Count(s => s.Status == BotStatus.Running);
 
-            // Calculate volume and PnL from strategies
+            // Calculate volume from strategies
             var totalVolume = strategies.Sum(s => s.Volume);
-            var totalPnL = strategies.Sum(s => s.Pnl);
+            
+            // Calculate PnL directly from database positions (closed positions only)
+            var totalPnL = await _tradingService.GetGlobalPnLFromPositionsAsync();
 
             // Calculate real open interest and position count from actual positions
             var (totalOpenInterest, totalPositionCount) = await CalculatePositionMetricsAsync();
@@ -317,7 +319,11 @@ public class PlatformSummaryGrain : Grain, IPlatformSummaryGrain, IRemindable
             }
 
             _state.State.TotalPlatformVolume += evt.Volume;
-            _state.State.TotalPlatformPnL += evt.RealizedPnL;
+            
+            // PnL is now calculated directly from database positions, not from events
+            // This ensures accuracy and prevents double-counting issues
+            // Refresh PnL from database to get the latest accurate value
+            await RefreshPnLFromDatabaseAsync();
 
             // Update volume by asset
             var asset = evt.Ticker;
@@ -452,6 +458,20 @@ public class PlatformSummaryGrain : Grain, IPlatformSummaryGrain, IRemindable
         await _state.WriteStateAsync();
     }
 
+    private async Task RefreshPnLFromDatabaseAsync()
+    {
+        try
+        {
+            var totalPnL = await _tradingService.GetGlobalPnLFromPositionsAsync();
+            _state.State.TotalPlatformPnL = totalPnL;
+            _logger.LogDebug("Refreshed PnL from database: {TotalPnL}", totalPnL);
+        }
+        catch (Exception ex)
+        {
+            _logger.LogError(ex, "Error refreshing PnL from database");
+        }
+    }
+
     private bool IsDataStale()
     {
         var timeSinceLastUpdate = DateTime.UtcNow - _state.State.LastUpdated;

src/Managing.Application/Trading/TradingService.cs

@@ -273,6 +273,11 @@ public class TradingService : ITradingService
         return await _tradingRepository.GetPositionsByInitiatorIdentifiersAsync(initiatorIdentifiers);
     }
 
+    public async Task<decimal> GetGlobalPnLFromPositionsAsync()
+    {
+        return await _tradingRepository.GetGlobalPnLFromPositionsAsync();
+    }
+
     private async Task ManageTrader(TraderFollowup a, List<Ticker> tickers)
     {
         var shortAddress = a.Account.Address.Substring(0, 6);