Oda/managing-apps
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactoring TradingBotBase.cs + clean architecture (#38)

Browse Source 
* Refactoring TradingBotBase.cs + clean architecture

* Fix basic tests

* Fix tests

* Fix workers

* Fix open positions

* Fix closing position stucking the grain

* Fix comments

* Refactor candle handling to use IReadOnlyList for chronological order preservation across various components
This commit is contained in:
Oda
2025-12-01 19:32:06 +07:00
committed by GitHub
parent ab26260f6d
commit 9d536ea49e
74 changed files with 4525 additions and 2350 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Managing.Domain/Indicators/Signals/MacdCrossIndicatorBase.cs
View File

@@ -21,7 +21,7 @@ public class MacdCrossIndicatorBase : IndicatorBase
SignalPeriods = signalPeriods;
}
public override List<LightSignal> Run(HashSet<Candle> candles)
public override List<LightSignal> Run(IReadOnlyList<Candle> candles)
{
if (candles.Count <= 2 * (SlowPeriods + SignalPeriods))
{
@@ -47,7 +47,7 @@ public class MacdCrossIndicatorBase : IndicatorBase
/// <summary>
/// Runs the indicator using pre-calculated MACD values for performance optimization.
/// </summary>
public override List<LightSignal> Run(HashSet<Candle> candles, IndicatorsResultBase preCalculatedValues)
public override List<LightSignal> Run(IReadOnlyList<Candle> candles, IndicatorsResultBase preCalculatedValues)
{
if (candles.Count <= 2 * (SlowPeriods + SignalPeriods))
{
@@ -88,7 +88,7 @@ public class MacdCrossIndicatorBase : IndicatorBase
/// </summary>
/// <param name="macd">List of MACD calculation results</param>
/// <param name="candles">Candles to process</param>
private void ProcessMacdSignals(List<MacdResult> macd, HashSet<Candle> candles)
private void ProcessMacdSignals(List<MacdResult> macd, IReadOnlyList<Candle> candles)
{
var macdCandle = MapMacdToCandle(macd, candles.TakeLast(SignalPeriods.Value));
@@ -114,7 +114,7 @@ public class MacdCrossIndicatorBase : IndicatorBase
}
}
public override IndicatorsResultBase GetIndicatorValues(HashSet<Candle> candles)
public override IndicatorsResultBase GetIndicatorValues(IReadOnlyList<Candle> candles)
{
return new IndicatorsResultBase()
{