Remove candle from backtest

src/Managing.Api/Controllers/BacktestController.cs

@@ -213,7 +213,8 @@ public class BacktestController : BaseController
                 request.StartDate,
                 request.EndDate,
                 user,
-                request.Save);
+                request.Save,
+                request.WithCandles);
 
             await NotifyBacktesingSubscriberAsync(backtestResult);
 
@@ -274,4 +275,10 @@ public class RunBacktestRequest
     /// Whether to save the backtest results
     /// </summary>
     public bool Save { get; set; } = false;
+
+    /// <summary>
+    /// Whether to include candles and indicators values in the response.
+    /// Set to false to reduce response size dramatically.
+    /// </summary>
+    public bool WithCandles { get; set; } = false;
 }

src/Managing.Api/Controllers/DataController.cs

@@ -1,12 +1,16 @@
-using Managing.Api.Models.Responses;
+using Managing.Api.Models.Requests;
+using Managing.Api.Models.Responses;
 using Managing.Application.Abstractions;
 using Managing.Application.Abstractions.Services;
 using Managing.Application.Hubs;
 using Managing.Application.ManageBot.Commands;
 using Managing.Domain.Bots;
 using Managing.Domain.Candles;
+using Managing.Domain.Scenarios;
 using Managing.Domain.Shared.Helpers;
 using Managing.Domain.Statistics;
+using Managing.Domain.Strategies;
+using Managing.Domain.Strategies.Base;
 using Managing.Domain.Trades;
 using MediatR;
 using Microsoft.AspNetCore.Authorization;
@@ -30,6 +34,7 @@ public class DataController : ControllerBase
     private readonly IStatisticService _statisticService;
     private readonly IHubContext<CandleHub> _hubContext;
     private readonly IMediator _mediator;
+    private readonly ITradingService _tradingService;
 
     /// <summary>
     /// Initializes a new instance of the <see cref="DataController"/> class.
@@ -40,13 +45,15 @@ public class DataController : ControllerBase
     /// <param name="statisticService">Service for statistical analysis.</param>
     /// <param name="hubContext">SignalR hub context for real-time communication.</param>
     /// <param name="mediator">Mediator for handling commands and queries.</param>
+    /// <param name="tradingService">Service for trading operations.</param>
     public DataController(
         IExchangeService exchangeService,
         IAccountService accountService,
         ICacheService cacheService,
         IStatisticService statisticService,
         IHubContext<CandleHub> hubContext,
-        IMediator mediator)
+        IMediator mediator,
+        ITradingService tradingService)
     {
         _exchangeService = exchangeService;
         _accountService = accountService;
@@ -54,6 +61,7 @@ public class DataController : ControllerBase
         _statisticService = statisticService;
         _hubContext = hubContext;
         _mediator = mediator;
+        _tradingService = tradingService;
     }
 
     /// <summary>
@@ -211,19 +219,55 @@ public class DataController : ControllerBase
     }
 
     /// <summary>
-    /// Retrieves candle data for a given exchange, ticker, start date, and timeframe.
+    /// Retrieves candles with indicators values for backtest details display.
     /// </summary>
-    /// <param name="exchange">The exchange to retrieve candles from.</param>
-    /// <param name="ticker">The ticker symbol to retrieve candles for.</param>
-    /// <param name="startDate">The start date for the candle data.</param>
-    /// <param name="timeframe">The timeframe for the candle data.</param>
-    /// <returns>A list of <see cref="Candle"/> objects.</returns>
+    /// <param name="exchange">The trading exchange.</param>
+    /// <param name="ticker">The ticker symbol.</param>
+    /// <param name="startDate">The start date for the candles.</param>
+    /// <param name="endDate">The end date for the candles.</param>
+    /// <param name="timeframe">The timeframe for the candles.</param>
+    /// <param name="scenario">The scenario object to calculate indicators values (optional).</param>
+    /// <returns>A response containing candles and indicators values.</returns>
     [Authorize]
-    [HttpGet("GetCandles")]
-    public async Task<ActionResult<List<Candle>>> GetCandles(TradingExchanges exchange, Ticker ticker,
-        DateTime startDate, Timeframe timeframe)
+    [HttpPost("GetCandlesWithIndicators")]
+    public async Task<ActionResult<CandlesWithIndicatorsResponse>> GetCandlesWithIndicators(
+        [FromBody] GetCandlesWithIndicatorsRequest request)
     {
-        return Ok(await _exchangeService.GetCandlesInflux(exchange, ticker, startDate, timeframe));
+        try
+        {
+            // Get candles for the specified period
+            var candles = await _exchangeService.GetCandlesInflux(TradingExchanges.Evm, request.Ticker,
+                request.StartDate, request.Timeframe, request.EndDate);
+
+            if (candles == null || candles.Count == 0)
+            {
+                return Ok(new CandlesWithIndicatorsResponse
+                {
+                    Candles = new List<Candle>(),
+                    IndicatorsValues = new Dictionary<IndicatorType, IndicatorsResultBase>()
+                });
+            }
+
+            // Calculate indicators values if scenario is provided
+            Dictionary<IndicatorType, IndicatorsResultBase> indicatorsValues = null;
+            if (request.Scenario != null && request.Scenario.Indicators != null &&
+                request.Scenario.Indicators.Count > 0)
+            {
+                // Map ScenarioRequest to domain Scenario object
+                var domainScenario = MapScenarioRequestToScenario(request.Scenario);
+                indicatorsValues = await _tradingService.CalculateIndicatorsValuesAsync(domainScenario, candles);
+            }
+
+            return Ok(new CandlesWithIndicatorsResponse
+            {
+                Candles = candles,
+                IndicatorsValues = indicatorsValues ?? new Dictionary<IndicatorType, IndicatorsResultBase>()
+            });
+        }
+        catch (Exception ex)
+        {
+            return StatusCode(500, $"Error retrieving candles with indicators: {ex.Message}");
+        }
     }
 
     /// <summary>
@@ -605,4 +649,35 @@ public class DataController : ControllerBase
 
         return Ok(response);
     }
+
+    /// <summary>
+    /// Maps a ScenarioRequest to a domain Scenario object.
+    /// </summary>
+    /// <param name="scenarioRequest">The scenario request to map.</param>
+    /// <returns>A domain Scenario object.</returns>
+    private Scenario MapScenarioRequestToScenario(ScenarioRequest scenarioRequest)
+    {
+        var scenario = new Scenario(scenarioRequest.Name, scenarioRequest.LoopbackPeriod);
+
+        foreach (var indicatorRequest in scenarioRequest.Indicators)
+        {
+            var indicator = new Indicator(indicatorRequest.Name, indicatorRequest.Type)
+            {
+                SignalType = indicatorRequest.SignalType,
+                MinimumHistory = indicatorRequest.MinimumHistory,
+                Period = indicatorRequest.Period,
+                FastPeriods = indicatorRequest.FastPeriods,
+                SlowPeriods = indicatorRequest.SlowPeriods,
+                SignalPeriods = indicatorRequest.SignalPeriods,
+                Multiplier = indicatorRequest.Multiplier,
+                SmoothPeriods = indicatorRequest.SmoothPeriods,
+                StochPeriods = indicatorRequest.StochPeriods,
+                CyclePeriods = indicatorRequest.CyclePeriods
+            };
+
+            scenario.AddIndicator(indicator);
+        }
+
+        return scenario;
+    }
 }

src/Managing.Api/Models/Requests/GetCandlesWithIndicatorsRequest.cs

@@ -0,0 +1,36 @@
+using static Managing.Common.Enums;
+
+namespace Managing.Api.Models.Requests;
+
+/// <summary>
+/// Request model for getting candles with indicators.
+/// </summary>
+public class GetCandlesWithIndicatorsRequest
+{
+
+
+    /// <summary>
+    /// The ticker symbol.
+    /// </summary>
+    public Ticker Ticker { get; set; }
+
+    /// <summary>
+    /// The start date for the candle data.
+    /// </summary>
+    public DateTime StartDate { get; set; }
+
+    /// <summary>
+    /// The end date for the candle data.
+    /// </summary>
+    public DateTime EndDate { get; set; }
+
+    /// <summary>
+    /// The timeframe for the candles.
+    /// </summary>
+    public Timeframe Timeframe { get; set; }
+
+    /// <summary>
+    /// Optional scenario for calculating indicators.
+    /// </summary>
+    public ScenarioRequest Scenario { get; set; }
+} 

src/Managing.Api/Models/Responses/CandlesWithIndicatorsResponse.cs

@@ -0,0 +1,21 @@
+using Managing.Domain.Candles;
+using Managing.Domain.Strategies.Base;
+using static Managing.Common.Enums;
+
+namespace Managing.Api.Models.Responses;
+
+/// <summary>
+/// Response model for candles with indicators values.
+/// </summary>
+public class CandlesWithIndicatorsResponse
+{
+    /// <summary>
+    /// The list of candles.
+    /// </summary>
+    public List<Candle> Candles { get; set; } = new List<Candle>();
+
+    /// <summary>
+    /// The calculated indicators values.
+    /// </summary>
+    public Dictionary<IndicatorType, IndicatorsResultBase> IndicatorsValues { get; set; } = new Dictionary<IndicatorType, IndicatorsResultBase>();
+}