Oda/managing-apps
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix status and filtered positions for metrics

Browse Source
This commit is contained in:
cryptooda
2025-10-08 18:37:38 +07:00
parent 86dd6849ea
commit 76b087a6e4
8 changed files with 57 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Managing.Domain/Shared/Helpers/TradingBox.cs
View File

@@ -454,11 +454,11 @@ public static class TradingBox
/// </summary>
/// <param name="positions">List of positions to analyze</param>
/// <returns>The total volume traded in decimal</returns>
public static decimal GetTotalVolumeTraded(Dictionary<Guid, Position> positions)
public static decimal GetTotalVolumeTraded(List<Position> positions)
{
decimal totalVolume = 0;
foreach (var position in positions.Values)
foreach (var position in positions)
{
// Add entry volume
totalVolume += position.Open.Quantity * position.Open.Price;
@@ -530,12 +530,12 @@ public static class TradingBox
/// </summary>
/// <param name="positions">List of positions to analyze</param>
/// <returns>A tuple containing (wins, losses)</returns>
public static (int Wins, int Losses) GetWinLossCount(Dictionary<Guid, Position> positions)
public static (int Wins, int Losses) GetWinLossCount(List<Position> positions)
{
int wins = 0;
int losses = 0;
foreach (var position in positions.Values)
foreach (var position in positions)
{
if (position.ProfitAndLoss != null && position.ProfitAndLoss.Realized > 0)
{

12
src/Managing.Domain/Trades/Position.cs
View File

@@ -141,7 +141,7 @@ namespace Managing.Domain.Trades
/// Gets the net PnL after deducting fees
/// </summary>
/// <returns>The net PnL after fees</returns>
public decimal GetNetPnL()
public decimal GetPnLBeforeFees()
{
if (ProfitAndLoss?.Realized == null)
{
@@ -151,6 +151,16 @@ namespace Managing.Domain.Trades
return ProfitAndLoss.Realized;
}
public decimal GetNetPnl()
{
if (ProfitAndLoss?.Net == null)
{
return 0;
}
return ProfitAndLoss.Realized - UiFees - GasFees;
}
/// <summary>
/// Updates the UI fees for this position
/// </summary>