Oda/managing-apps
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix realized pnl on backtest save + add tests (not all passing)

Browse Source
This commit is contained in:
cryptooda
2025-11-14 02:38:15 +07:00
parent 1f7d914625
commit 460a7bd559
34 changed files with 6012 additions and 500 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Managing.Application/Trading/Handlers/ClosePositionCommandHandler.cs
View File

@@ -57,7 +57,7 @@ public class ClosePositionCommandHandler(
// Add UI fees for closing the position (broker closed it)
var closingPositionSizeUsd =
(lastPrice * request.Position.Open.Quantity) * request.Position.Open.Leverage;
var closingUiFees = TradingHelpers.CalculateClosingUiFees(closingPositionSizeUsd);
var closingUiFees = TradingBox.CalculateClosingUiFees(closingPositionSizeUsd);
request.Position.AddUiFees(closingUiFees);
request.Position.AddGasFees(Constants.GMX.Config.GasFeePerTransaction);
@@ -83,7 +83,7 @@ public class ClosePositionCommandHandler(
// Add UI fees for closing the position
var closingPositionSizeUsd = (lastPrice * closedPosition.Quantity) * request.Position.Open.Leverage;
var closingUiFees = TradingHelpers.CalculateClosingUiFees(closingPositionSizeUsd);
var closingUiFees = TradingBox.CalculateClosingUiFees(closingPositionSizeUsd);
request.Position.AddUiFees(closingUiFees);
request.Position.AddGasFees(Constants.GMX.Config.GasFeePerTransaction);

6
src/Managing.Application/Trading/Handlers/OpenPositionCommandHandler.cs
View File

@@ -89,11 +89,11 @@ namespace Managing.Application.Trading.Handlers
// Calculate and set fees for the position
position.GasFees = TradingHelpers.CalculateOpeningGasFees();
position.GasFees = TradingBox.CalculateOpeningGasFees();
// Set UI fees for opening
var positionSizeUsd = TradingHelpers.GetVolumeForPosition(position);
position.UiFees = TradingHelpers.CalculateOpeningUiFees(positionSizeUsd);
var positionSizeUsd = TradingBox.GetVolumeForPosition(position);
position.UiFees = TradingBox.CalculateOpeningUiFees(positionSizeUsd);
var closeDirection = request.Direction == TradeDirection.Long
? TradeDirection.Short