Oda/managing-apps
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "orleans health, dont count dead silos"

Browse Source 
This reverts commit ad8848cef5.
This commit is contained in:
cryptooda
2025-10-03 12:59:56 +07:00
parent ad8848cef5
commit 43d301e47a
1 changed files with 20 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/Managing.Api/HealthChecks/OrleansHealthCheck.cs
View File

@@ -340,30 +340,35 @@ namespace Managing.Api.HealthChecks
var expectedActiveSilos = localhostEnvironment ? 1 : 2; // Localhost: 1, Sandbox: 2 var expectedActiveSilos = localhostEnvironment ? 1 : 2; // Localhost: 1, Sandbox: 2
metricsInfo["ExpectedActiveSilos"] = expectedActiveSilos; metricsInfo["ExpectedActiveSilos"] = expectedActiveSilos;
// Check for health issues based on expected vs actual active silos // Check for health issues based on environment
if (activeSilos == 0) if (activeSilos == 0)
{ {
issues.Add("No active silos found"); issues.Add("No active silos found");
} }
else if (activeSilos < expectedActiveSilos) else if (localhostEnvironment)
{ {
issues.Add($"Expected {expectedActiveSilos} active silos, found {activeSilos}"); // In localhost, we expect exactly 1 active silo
} if (activeSilos != 1)
else if (activeSilos > expectedActiveSilos) {
{ issues.Add($"Localhost environment should have exactly 1 active silo, found {activeSilos}");
issues.Add($"Expected {expectedActiveSilos} active silos, found {activeSilos} (more than expected)"); }
} // Dead silos in localhost are normal (from previous runs)
if (deadSilos > 0)
// Add informational note about dead silos without affecting health status
if (deadSilos > 0)
{
if (localhostEnvironment)
{ {
metricsInfo["DeadSilosNote"] = "Dead silos in localhost are normal (from previous runs)"; metricsInfo["DeadSilosNote"] = "Dead silos in localhost are normal (from previous runs)";
} }
else }
else
{
// In sandbox/production, we expect at least 2 active silos for redundancy
if (activeSilos < 2)
{ {
metricsInfo["DeadSilosNote"] = $"Found {deadSilos} dead silos (monitoring for cleanup)"; issues.Add($"Production environment should have at least 2 active silos for redundancy, found {activeSilos}");
}
// Dead silos in production are concerning
if (deadSilos > 0)
{
issues.Add($"Found {deadSilos} dead silos in production environment");
} }
} }
} }