Fix backup (#5)

src/Managing.Application/Abstractions/IBotService.cs

@@ -7,8 +7,8 @@ namespace Managing.Application.Abstractions;
 
 public interface IBotService
 {
-    void SaveBotBackup(BotBackup botBackup);
-    void SaveBotBackup(string name, Enums.BotType botType, string data);
+    void SaveOrUpdateBotBackup(BotBackup botBackup);
+    void SaveOrUpdateBotBackup(string name, Enums.BotType botType, string data);
     void AddSimpleBotToCache(IBot bot);
     void AddTradingBotToCache(ITradingBot bot);
     List<ITradingBot> GetActiveBots();
@@ -31,4 +31,5 @@ public interface IBotService
     Task<string> StopBot(string requestName);
     Task<bool> DeleteBot(string requestName);
     Task<string> RestartBot(string requestName);
+    void DeleteBotBackup(string backupBotName);
 }

src/Managing.Application/Bots/SimpleBot.cs

@@ -45,7 +45,7 @@ namespace Managing.Application.Bots
         public override void SaveBackup()
         {
             var data = JsonConvert.SerializeObject(_workflow);
-            _botService.SaveBotBackup(Name, BotType.SimpleBot, data);
+            _botService.SaveOrUpdateBotBackup(Name, BotType.SimpleBot, data);
         }
 
         public override void LoadBackup(BotBackup backup)

src/Managing.Application/Bots/TradingBot.cs

@@ -714,7 +714,7 @@ public class TradingBot : Bot, ITradingBot
             WalletBalances = WalletBalances,
             MoneyManagement = MoneyManagement
         };
-        BotService.SaveBotBackup(Name, BotType, JsonConvert.SerializeObject(data));
+        BotService.SaveOrUpdateBotBackup(Name, BotType, JsonConvert.SerializeObject(data));
     }
 
     public override void LoadBackup(BotBackup backup)

src/Managing.Application/ManageBot/BotService.cs

@@ -35,7 +35,7 @@ namespace Managing.Application.ManageBot
             _tradingService = tradingService;
         }
 
-        public async void SaveBotBackup(BotBackup botBackup)
+        public async void SaveOrUpdateBotBackup(BotBackup botBackup)
         {
             await _botRepository.InsertBotAsync(botBackup);
         }
@@ -45,7 +45,7 @@ namespace Managing.Application.ManageBot
             return _botRepository.GetBots().FirstOrDefault(b => b.Name == name);
         }
 
-        public void SaveBotBackup(string name, Enums.BotType botType, string data)
+        public void SaveOrUpdateBotBackup(string name, Enums.BotType botType, string data)
         {
             var backup = GetBotBackup(name);
 
@@ -53,17 +53,18 @@ namespace Managing.Application.ManageBot
             {
                 backup.Data = data;
                 _botRepository.UpdateBackupBot(backup);
-                return;
             }
-
-            var botBackup = new BotBackup
+            else
             {
-                Name = name,
-                BotType = botType,
-                Data = data
-            };
+                var botBackup = new BotBackup
+                {
+                    Name = name,
+                    BotType = botType,
+                    Data = data
+                };
 
-            _botRepository.InsertBotAsync(botBackup);
+                _botRepository.InsertBotAsync(botBackup);
+            }
         }
 
         public class BotTaskWrapper
@@ -197,6 +198,11 @@ namespace Managing.Application.ManageBot
             return Task.FromResult(Enums.BotStatus.Down.ToString());
         }
 
+        public void DeleteBotBackup(string backupBotName)
+        {
+            _botRepository.DeleteBotBackup(backupBotName);
+        }
+
         public ITradingBot CreateScalpingBot(string accountName, MoneyManagement moneyManagement, string name,
             Enums.Ticker ticker, string scenario, Enums.Timeframe interval, bool isForWatchingOnly)
         {

src/Managing.Application/ManageBot/LoadBackupBotCommandHandler.cs

@@ -74,6 +74,7 @@ public class LoadBackupBotCommandHandler : IRequestHandler<LoadBackupBotCommand,
             catch (Exception ex)
             {
                 _logger.LogError($"Error loading bot {backupBot.Name}", ex.Message);
+                _botService.DeleteBotBackup(backupBot.Name);
                 result.Add(backupBot.Name, BotStatus.Down);
             }
         }

src/Managing.Application/ManageBot/StartBotCommandHandler.cs

@@ -27,19 +27,16 @@ namespace Managing.Application.ManageBot
             {
                 case BotType.SimpleBot:
                     var bot = _botFactory.CreateSimpleBot(request.Name, null);
-                    bot.Start();
                     _botService.AddSimpleBotToCache(bot);
                     return Task.FromResult(bot.GetStatus());
                 case BotType.ScalpingBot:
                     var sBot = _botFactory.CreateScalpingBot(request.AccountName, moneyManagement, request.Name,
                         request.Ticker, request.Scenario, request.Timeframe, request.IsForWatchingOnly);
-                    sBot.Start();
                     _botService.AddTradingBotToCache(sBot);
                     return Task.FromResult(sBot.GetStatus());
                 case BotType.FlippingBot:
                     var fBot = _botFactory.CreateFlippingBot(request.AccountName, moneyManagement, request.Name,
                         request.Ticker, request.Scenario, request.Timeframe, request.IsForWatchingOnly);
-                    fBot.Start();
                     _botService.AddTradingBotToCache(fBot);
                     return Task.FromResult(fBot.GetStatus());
             }